Skip to content

New p2wpkh methods#9

Open
JavierCervilla wants to merge 3 commits intodfinity:mainfrom
JavierCervilla:new_p2w_methods
Open

New p2wpkh methods#9
JavierCervilla wants to merge 3 commits intodfinity:mainfrom
JavierCervilla:new_p2w_methods

Conversation

@JavierCervilla
Copy link
Copy Markdown

  • Add support for P2wpkh addresses following the same module structure that P2pkh
  • Add test suite for P2wpkh addresses following the same test suite structure

@JavierCervilla JavierCervilla requested a review from a team April 15, 2025 18:03
@github-actions
Copy link
Copy Markdown

Thank you for contributing! Unfortunately this repository does not accept external contributions yet.

We are working on enabling this by aligning our internal processes and our CI setup to handle external contributions. However this will take some time to set up so in the meantime we unfortunately have to close this Pull Request.

We hope you understand and will come back once we accept external PRs.

— The DFINITY Foundation"""

@github-actions github-actions Bot closed this Apr 15, 2025
@letmejustputthishere
Copy link
Copy Markdown

FYI, it might take a couple weeks before this can be merged as the devs are currently busy with other high priority work items. thanks for understanding!

@cla-idx-bot
Copy link
Copy Markdown

cla-idx-bot Bot commented Jul 15, 2025

Dear @JavierCervilla,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

@randombit
Copy link
Copy Markdown

@JavierCervilla sorry about the extended delay in looking at this PR. But now the repo is available for public contributions, and from a brief look this seems a valuable addition to the library. We (the DFINITY cryptography team) are probably not going to perform a full review of this PR until the CLA is signed, since that is a necessary precondition to us merging the PR in any case. Once the CLA is signed please ping me in this PR discussion and someone will then review asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants